abdullah alamoudi has posted comments on this change.

Change subject: Support Change Feeds and Ingestion of Records with 
MetaData(WIP-rebased)
......................................................................


Patch Set 5:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/621/5/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/UnnestToDataScanRule.java
File 
asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/UnnestToDataScanRule.java:

Line 175:                 // Add unnest variables
> remove from unnest. create here!
Done


https://asterix-gerrit.ics.uci.edu/#/c/621/5/asterix-algebra/src/main/java/org/apache/asterix/translator/CompiledStatements.java
File 
asterix-algebra/src/main/java/org/apache/asterix/translator/CompiledStatements.java:

Line 441: 
> find a better place for this.
Done


https://asterix-gerrit.ics.uci.edu/#/c/621/5/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
File 
asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java:

Line 323:                     stmt.getDatasetName());
> change this. introduce meta record in the re-write rule.
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/621
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If136a03d424970132dfb09f0dda56e160d4c0078
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <[email protected]>
Gerrit-Reviewer: Ildar Absalyamov <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Steven Jacobs <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to