Yingyi Bu has posted comments on this change. Change subject: Support Change Feeds and Ingestion of Records with MetaData ......................................................................
Patch Set 9: (8 comments) https://asterix-gerrit.ics.uci.edu/#/c/620/9/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/AbstractFunctionCallExpression.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/AbstractFunctionCallExpression.java: Line 151: Iterator<Mutable<ILogicalExpression>> it = arguments.iterator(); Do you still need this method? https://asterix-gerrit.ics.uci.edu/#/c/620/9/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/BulkloadPOperator.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/BulkloadPOperator.java: Line 107: insertDeleteOp.getAdditionalNonFilteringExpressions(), inputDesc, context, spec, true); pass a list of variables for additionalNonFilteringFields. https://asterix-gerrit.ics.uci.edu/#/c/620/9/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/plan/ALogicalPlanImpl.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/plan/ALogicalPlanImpl.java: Line 68: return e.getMessage(); Throws this exception out. https://asterix-gerrit.ics.uci.edu/#/c/620/9/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java File algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java: Line 312: ArrayList<LogicalVariable> additionalNonFilterVariables = null; ArrayList->List Line 317: .add(((VariableReferenceExpression) expr.getValue()).getVariableReference()); Use the Java8 feature? foor loop --> opLoad.getAdditionalNonFiltering Expressions().foreach(expr -> additionalNonFilterVariables .add(((expr) expr.getValue()).getVari ableReference())); https://asterix-gerrit.ics.uci.edu/#/c/620/9/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/FrameTupleAccessor.java File hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/FrameTupleAccessor.java: Line 209: e.printStackTrace(); throws exception out? Line 230: e.printStackTrace(); throws exception out? https://asterix-gerrit.ics.uci.edu/#/c/620/9/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/FileSplit.java File hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/FileSplit.java: Line 84: } It would be nice to keep the class immutable. Thus, it's nice to remove this set method to be consistent with other members, unless it is absolutely necessary. -- To view, visit https://asterix-gerrit.ics.uci.edu/620 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3749349e2b9f1b03c8b310eb99d3f44d08be77df Gerrit-PatchSet: 9 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
