abdullah alamoudi has posted comments on this change. Change subject: Support Change Feeds and Ingestion of Records with MetaData ......................................................................
Patch Set 12: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/620/12/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/BulkloadPOperator.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/BulkloadPOperator.java: Line 103: List<Mutable<ILogicalExpression>> expressions = insertDeleteOp.getAdditionalNonFilteringExpressions(); > Can you use the way this operator uses for payload, primaryKeys, and additi Done https://asterix-gerrit.ics.uci.edu/#/c/620/12/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractCommonExpressionsRule.java File algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractCommonExpressionsRule.java: Line 104: ignoreOps.add(LogicalOperatorTag.INSERT_DELETE_UPSERT); > You don't need to disable it now, I guess. Yes, I don't. https://asterix-gerrit.ics.uci.edu/#/c/620/12/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java File algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java: Line 315: opLoad.getAdditionalNonFilteringExpressions().forEach(expr -> additionalNonFilterVariables > move that if block to line 307 so that it can be shared by both bulkload an Done Line 315: opLoad.getAdditionalNonFilteringExpressions().forEach(expr -> additionalNonFilterVariables > move that if block to line 307 so that it can be shared by both bulkload an Done -- To view, visit https://asterix-gerrit.ics.uci.edu/620 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3749349e2b9f1b03c8b310eb99d3f44d08be77df Gerrit-PatchSet: 12 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
