abdullah alamoudi has posted comments on this change. Change subject: - Reapplied fix for ASTERIXDB-1109 on merged master - Cleaned up runtime testsuite, made it validate against XSD ......................................................................
Patch Set 4: Code-Review+1 (3 comments) Hi Ildar, I looked at it and it looks good to me. rebase it and when it builds successfully, I will +2 it. https://asterix-gerrit.ics.uci.edu/#/c/712/4/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceMaterializationForInsertWithSelfScanRule.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceMaterializationForInsertWithSelfScanRule.java: Line 44: Not sure if it is but probably not. Here is a LIKE https://asterix-gerrit.ics.uci.edu/#/c/712/4/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/index-selection/multi-index-composite-key/multi-index-composite-key.2.update.aql File asterix-app/src/test/resources/runtimets/queries/open-index-enforced/index-selection/multi-index-composite-key/multi-index-composite-key.2.update.aql: Line 31: using "org.apache.asterix.external.dataset.adapter.NCFileSystemAdapter" change to localfs. otherwise, it will not build https://asterix-gerrit.ics.uci.edu/#/c/712/4/asterix-app/src/test/resources/runtimets/queries/open-index-enforced/index-selection/multi-index/multi-index.2.update.aql File asterix-app/src/test/resources/runtimets/queries/open-index-enforced/index-selection/multi-index/multi-index.2.update.aql: Line 22: using "org.apache.asterix.external.dataset.adapter.NCFileSystemAdapter" change to "using localfs" -- To view, visit https://asterix-gerrit.ics.uci.edu/712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fcf41c009f9faf51bc8bccc0c3c7217b7769121 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
