abdullah alamoudi has posted comments on this change. Change subject: Fixed Feed Connect Statement ......................................................................
Patch Set 2: (4 comments) Addressed Murtadha's comments and rebased on master https://asterix-gerrit.ics.uci.edu/#/c/726/2/asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java File asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java: Line 158: > make synchronized Done Line 168: } else { > increment job count Done Line 298: > double check whether synchronized is needed? Done https://asterix-gerrit.ics.uci.edu/#/c/726/2/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java File asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java: Line 118: feedSubscriptionManager.registerFeedSubscribableRuntime(ingestionRuntime); > add comment! Done -- To view, visit https://asterix-gerrit.ics.uci.edu/726 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I416bf4917b1f5cea687d1202c435f7183136cf1f Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
