Taewoo Kim has posted comments on this change. Change subject: Upto threeway fuzzy join based on prefix pruning ......................................................................
Patch Set 15: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/530/15/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractCommonOperatorsRule.java File algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractCommonOperatorsRule.java: Line 449: // operas as well as the expression translation. buy the same operas: what does this mean? Line 452: isHomo = true; Why don't we throw an exception for the inner-join case? Line 458: for (int i = 0; i < 2; i++) { Rather than "i < 2", "i < candidate.getInputs().size()" would be more general. -- To view, visit https://asterix-gerrit.ics.uci.edu/530 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2487078d1821d7ad85bb745bfa31024bcdbea1f1 Gerrit-PatchSet: 15 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Chen Li <[email protected]> Gerrit-Reviewer: Inci Cetindil <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Wenhai Li <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
