Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1360 Fix Error Message for Unknown Format ......................................................................
Patch Set 8: Code-Review+1 (2 comments) Looks good to me. My questions could be addressed by adding JIRAs to answer them as they might need a broader discussion. https://asterix-gerrit.ics.uci.edu/#/c/767/8/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java: Line 105: || reader.equals(ExternalDataConstants.READER_PULL_TWITTER)) { Is there a difference between these 2 constants? https://asterix-gerrit.ics.uci.edu/#/c/767/8/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java File asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java: Line 127: public static final String READER_PULL_TWITTER = "pull_twitter"; Why are these "_" separated while the other ones are "-" separated? Do we have rules how to decide this? -- To view, visit https://asterix-gerrit.ics.uci.edu/767 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4aac833e30bd7c5a7706f5c8116383c2362c964 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
