Murtadha Hubail has posted comments on this change. Change subject: ASTERIXDB-1356: report file not found ......................................................................
Patch Set 3: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/771/3/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java File asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java: Line 78: keys.clear(); I would throw an exception here if the dir list is empty. Line 91: } throw an exception here if the files list is empty. https://asterix-gerrit.ics.uci.edu/#/c/771/3/asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java File asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java: Line 67: }); > Clearly my intent was on fixing the issue, that I got a success message wit Given the parameters passed to this method, I don't think enum is appropriate. Since this is a util method, I would change this method back to void and just throw an exception in case the root doesn't exists. Let the caller checks whether the list of files or dir is empty and decide according his logic. -- To view, visit https://asterix-gerrit.ics.uci.edu/771 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
