Murtadha Hubail has posted comments on this change. Change subject: ASTERIXDB-1356: report file not found ......................................................................
Patch Set 8: As we discussed, for the first issue, it makes sense for external datasets, but not for loading. Since this code is generic for all cases now, it is okay to remove the empty files exception. As for the second issue, traverse is called inside the for loop for each path, so if one is not found, then an exception will be thrown. As we noticed, the current init method needs to be modified for feeds since resume() is called multiple times. Please submit a fix for it and remove the exception and add me as reviewer. -- To view, visit https://asterix-gerrit.ics.uci.edu/771 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
