Pritom Ahmed has posted comments on this change. Change subject: ASTERIXDB-1287: Fixed Admin Console pages. ......................................................................
Patch Set 4: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/557/4//COMMIT_MSG Commit Message: Line 25: raw JSON data sent to it. > Please follow the formatting guidelines for commit messages [1]. Done https://asterix-gerrit.ics.uci.edu/#/c/557/4/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java File hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java: Line 21: import java.util.*; > We usually don't use "*" includes. And as this is the only change here, the Done https://asterix-gerrit.ics.uci.edu/#/c/557/4/hyracks/hyracks-control/hyracks-control-cc/src/main/resources/static/javascript/adminconsole/json.human.js File hyracks/hyracks-control/hyracks-control-cc/src/main/resources/static/javascript/adminconsole/json.human.js: Line 21: // THE SOFTWARE. > We need to update the LICENSE and NOTICE for this. Actually these files previously had these licenses. Can we change the text and replace it with the Apache license ? /* Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ https://asterix-gerrit.ics.uci.edu/#/c/557/4/pom.xml File pom.xml: Line 211: <exclude>**/stylesheet/json.human.css</exclude> > Can we be more precise here (not "**")? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/557 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3944ed0c972f227aa1397d1cf6608f78f5f8c540 Gerrit-PatchSet: 4 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Pritom Ahmed <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Pritom Ahmed <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
