Murtadha Hubail has posted comments on this change. Change subject: Asterix-1389 Fix Deadlocks in Feed Connections ......................................................................
Patch Set 2: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/792/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/FeedJobNotificationHandler.java: Line 551 Return the implementation of this method. Line 583: public boolean registerFeedEventSubscriber(FeedConnectionId connectionId, change this back to void https://asterix-gerrit.ics.uci.edu/#/c/792/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java: Line 2197: subscriberRegistered = FeedLifecycleListener.INSTANCE.registerFeedEventSubscriber(feedConnId, This is always true. (Even before, but now the call always return true) https://asterix-gerrit.ics.uci.edu/#/c/792/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/IFeedLifecycleListener.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/IFeedLifecycleListener.java: Line 42: public boolean registerFeedEventSubscriber(FeedConnectionId connectionId, IFeedLifecycleEventSubscriber subscriber); return this to void -- To view, visit https://asterix-gerrit.ics.uci.edu/792 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2778b4d7f156c7e06ac9f561a26783c4933a22c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-HasComments: Yes
