Murtadha Hubail has posted comments on this change. Change subject: Fix ASTERIXDB-1011 issue: added flow control for merge policy ......................................................................
Patch Set 2: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/795/2//COMMIT_MSG Commit Message: Line 7: Fix ASTERIXDB-1011 issue: added flow control for merge policy Update to follow the standard as follows: ASTERIXDB-1011: added flow control for merge policy https://asterix-gerrit.ics.uci.edu/#/c/795/2/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java: Line 133: //TODO implement properly according to the merge policy Open JIRA issue for this. https://asterix-gerrit.ics.uci.edu/#/c/795/2/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ConstantMergePolicy.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ConstantMergePolicy.java: Line 73: break; add comment to why this should break. https://asterix-gerrit.ics.uci.edu/#/c/795/2/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java: Line 213: opTracker.wait(); if a merge operation causes this flush to wait, and at this stage the component has already been marked as valid, if the merge operation is interrupted (e.g. node failure or replica takeover), then the next flush after the instance restarts will wait forever since there is no on going merge. I think this should trigger a merge in case there is no on going merge. -- To view, visit https://asterix-gerrit.ics.uci.edu/795 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide99c022861f96cd60bc8f5795c4964ab02b3e14 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Young-Seok Kim <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-HasComments: Yes
