Till Westmann has posted comments on this change. Change subject: Add List of Supported Adapters to Doc ......................................................................
Patch Set 1: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/802/1/asterixdb/asterix-doc/src/site/markdown/aql/externaldata.md File asterixdb/asterix-doc/src/site/markdown/aql/externaldata.md: Line 43: <ol> Any reason for not using markdown lists [1]? Also, especially when using markdown lists, if makes a lot of sense to limit the line length (e.g. to our usual 120 chars) to make reading of the text file easier. [1] https://daringfireball.net/projects/markdown/syntax#list Line 44: <li>localfs: used for reading data stored in a local filesystem in one or more of the node controllers I think that it would be nicer to mark words that are literally used in code up as "code" using backticks (e.g. `localfs` and `path`). https://daringfireball.net/projects/markdown/syntax#code Line 46: <li>path: A fully qualified path of the form host://<absolute path>. Comma separated list if there are multiple directories or files</li> The URLs don't render very well in my browser. How about marking them up as "code" as well? Line 47: <li>expression: A regular expression to match and filter against file names</li> Would be nice to provide a link to the definition of the regex supported here - there are too many different kinds. Line 60: <li>sockets: comma separated list of sockets to listen to</li> WS Line 64: <li>socket_client: used for connecting to one or more socket and reading data streams. "one or more *sockets*" -- To view, visit https://asterix-gerrit.ics.uci.edu/802 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bb98477e144e78e9983d33f9dd2f89a547aeccf Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Chen Li <[email protected]> Gerrit-Reviewer: Heri Ramampiaro <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Michael Carey <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
