Murtadha Hubail has posted comments on this change. Change subject: Avoid 1 copy of the data when returning results ......................................................................
Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/808/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java: Line 143: if (bytesRead > 0) { This works just fine, but I suggest removing the do-while loop. Just remove the initial read from above and replace everything by while (resultReader.read(frame) > 0) -- To view, visit https://asterix-gerrit.ics.uci.edu/808 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8728b218e8f8e20d3e58be46c704f75ef2288933 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-HasComments: Yes
