Yingyi Bu has posted comments on this change. Change subject: Equivalence induced operations and the testCases ......................................................................
Patch Set 29: (3 comments) 1. My main concern is that the necessity of new classes like PreComputePartitionIdForRoutableOperationRule and ExpressionUtil need to be justified. In principle, it seems that the current inline variable rule and constant folding rule can be reused. Is it because of record-related functions? 2. Please use the right code style format: http://asterixdb.incubator.apache.org/dev-setup.html 3. Detailed comments are inlined. https://asterix-gerrit.ics.uci.edu/#/c/428/29/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/AnalysisUtil.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/AnalysisUtil.java: Line 139: public static Pair<String, String> getDatasetInfo(UnnestMapOperator unnestOp, IOptimizationContext ctx) remove ctx from parameters. Line 150: jobGenParams.getDatasetName()); replace line 148 - 153 with: return new Pair<String, String>(jobGenParams.getDataverseName(), jobGenParams.getDatasetName()); https://asterix-gerrit.ics.uci.edu/#/c/428/29/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/AddEquivalenceClassForRecordConstructorRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/AddEquivalenceClassForRecordConstructorRule.java: Line 133: Collection<ILogicalExpression> eprs = bToT.getExpressionMembers(); Are the two added-if blocks to add nested fields into the equivalent class? If that's the purpose, why the first block is needed? -- To view, visit https://asterix-gerrit.ics.uci.edu/428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaad567eecc4c91019ecba56cca085acde34d5196 Gerrit-PatchSet: 29 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wenhai Li <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
