Till Westmann has posted comments on this change. Change subject: Update the Key Value Reader ......................................................................
Patch Set 3: Code-Review+2 I think that this change it good. However, I think that the IRecordReader interface is confusing. The methods look as if this is an iterator but this is at least an uncommon way for an iterator to behave. I'd expect that if hasNext() returns true that next() will be able to return the next value (that's why it's called "hasNext"). If next() can also return null, all invocations of this interface need to check the result for null. But it seems that that's not the case (e.g. in RecordDataFlowController we don't check and pass the object on). I think that the interface that should be documented or changed and that we should ensure that all invocations of the interface follow the (documented) contract. Could you file an issue for that? -- To view, visit https://asterix-gerrit.ics.uci.edu/805 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54f8a313c871428b2468b74c0760e8d28e810699 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
