Till Westmann has posted comments on this change. Change subject: Bytecode generation for null-handling in SQL++ functions. ......................................................................
Patch Set 9: (5 comments) Very nice stuff :) I've got only a few questions. https://asterix-gerrit.ics.uci.edu/#/c/824/9/asterixdb/asterix-app/pom.xml File asterixdb/asterix-app/pom.xml: Line 190: <scope>test</scope> </dependency> --> Can we remove this instead of re-formatting it? https://asterix-gerrit.ics.uci.edu/#/c/824/9/asterixdb/asterix-maven-plugins/asterix-evaluator-generator-maven-plugin/src/main/java/org/apache/asterix/runtime/evaluators/plugin/EvaluatorGeneratorMojo.java File asterixdb/asterix-maven-plugins/asterix-evaluator-generator-maven-plugin/src/main/java/org/apache/asterix/runtime/evaluators/plugin/EvaluatorGeneratorMojo.java: Line 61: Reflections reflections = new Reflections("org.apache.asterix.runtime.evaluators"); It might be good to make this a parameter of the Mojo, e.g. if we have evaluators in other/external packages .. https://asterix-gerrit.ics.uci.edu/#/c/824/9/asterixdb/asterix-runtime/pom.xml File asterixdb/asterix-runtime/pom.xml: Line 80: <version>5.1</version> It's a little confusing that this dependency and the code in staticcodegen is in asterix-runtime. Shouldn't that be part of the maven-plugin (or a project that the maven plugin depdends on)? https://asterix-gerrit.ics.uci.edu/#/c/824/9/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/staticcodegen/GatherEvaluatorCreationVisitor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/staticcodegen/GatherEvaluatorCreationVisitor.java: Line 34: private static String OWNER_PREFIX = "org/apache/asterix/runtime/evaluators/"; Again, this might come in from the Mojo. https://asterix-gerrit.ics.uci.edu/#/c/824/9/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/staticcodegen/GatherEvaluatorFactoryCreationVisitor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/staticcodegen/GatherEvaluatorFactoryCreationVisitor.java: Line 34: private static String OWNER_PREFIX = "org/apache/asterix/runtime/evaluators/"; Again, this might come in from the Mojo. -- To view, visit https://asterix-gerrit.ics.uci.edu/824 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75d8abfad6b0a8c0d7faaac2e7fc7d4fea638e37 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
