Young-Seok Kim has posted comments on this change.

Change subject: MBR size optimization for point data in R-Tree
......................................................................


Patch Set 1:

(1 comment)

First, all hyracks level tests may not tell whether the test data is point or 
not since the data type can be specified in asterix level. Also, all those 
tests in the hyracks level give four doubles currently for the tests.
Second, I addressed the ternary operators as you suggested.

https://asterix-gerrit.ics.uci.edu/#/c/831/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java:

Line 285:             AlgebricksMetaOperatorDescriptor asterixAssignOp = 
createAssignOp(spec, sourceOp,
> I feel like making these just separate variables would be clearer. The use 
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/831
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48304a221f462c66bb1417f291b0ce4f2ce7581
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Young-Seok Kim <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Young-Seok Kim <[email protected]>
Gerrit-HasComments: Yes

Reply via email to