Ian Maxon has posted comments on this change. Change subject: Set LSMRTreeWithAntiMatterTuples as the default RTree for interal dataset ......................................................................
Patch Set 2: Code-Review+1 (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/838/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java: Line 321: IIndexDataflowHelperFactory idff = null; Why the set to null then initialize here? Also I guess I am trying to understand why the method here is called getComparatorFactoriesForDeletedKeyBTree(); Is this for backwards compat? https://asterix-gerrit.ics.uci.edu/#/c/838/2/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/AbstractLSMRTree.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/AbstractLSMRTree.java: Line 376: protected LSMRTreeOpContext createOpContext(IModificationOperationCallback modCallback, What's the purpose of this new callback? Is it because the antimatter RTree needs it? -- To view, visit https://asterix-gerrit.ics.uci.edu/838 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19323ef38335409bc914265502ae56655db6d106 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Young-Seok Kim <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-HasComments: Yes
