Ian Maxon has posted comments on this change. Change subject: Overhaul of Hyracks configuration management. ......................................................................
Patch Set 5: Code-Review+1 (1 comment) Overall seems fine to me, but have we tried mvn verify beforehand with this patch just out of an abundance of caution? https://asterix-gerrit.ics.uci.edu/#/c/336/5/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/pom.xml File hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/pom.xml: Line 63: <version>0.2.18-SNAPSHOT</version> Should change this to be ${hyracks.version} -- To view, visit https://asterix-gerrit.ics.uci.edu/336 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3027c8c839f25ea858790bd3340187f4b11f212 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Chris Hillery <[email protected]> Gerrit-Reviewer: Chris Hillery <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
