Michael Blow has posted comments on this change. Change subject: Big Object Support For Storage ......................................................................
Patch Set 6: (11 comments) from review w/ till & abdullah https://asterix-gerrit.ics.uci.edu/#/c/840/6/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/frames/BTreeNSMInteriorFrame.java File hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/frames/BTreeNSMInteriorFrame.java: Line 196: throw new IllegalStateException("Space required for record (" + tupleSize remove https://asterix-gerrit.ics.uci.edu/#/c/840/6/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/frames/BTreeNSMLeafFrame.java File hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/frames/BTreeNSMLeafFrame.java: Line 207: int pageSize = isLargePage() add TODO https://asterix-gerrit.ics.uci.edu/#/c/840/6/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java File hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java: Line 965: ); new line Line 979: ); new line Line 998: ); new line Line 1125: protected void propagateBulk(int level, List<ICachedPage> pagesToWrite) throws HyracksDataException, TreeIndexException { line too long https://asterix-gerrit.ics.uci.edu/#/c/840/6/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java: Line 247: ICachedPage rootNode = bufferCache.pin(BufferedFileHandle.getDiskPageId(fileId, rootPage), false, largePageHelper); line too long https://asterix-gerrit.ics.uci.edu/#/c/840/6/hyracks-fullstack/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/impls/RTree.java File hyracks-fullstack/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/impls/RTree.java: Line 850: final int pageSize = bufferCache.getPageSize(); remove https://asterix-gerrit.ics.uci.edu/#/c/840/6/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/ClockPageReplacementStrategy.java File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/ClockPageReplacementStrategy.java: Line 126: if (looped && clockPtr >= startClockPtr) { Need to log a warning here, we went through entire cycle without finding a victim. Line 177: // TODO: what should we do with we need to resize and don't have the budget? log, file jira issue on buffer cache exhaustion / starvation https://asterix-gerrit.ics.uci.edu/#/c/840/6/hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-btree-test/src/test/java/org/apache/hyracks/storage/am/btree/FieldPrefixNSMTest.java File hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-btree-test/src/test/java/org/apache/hyracks/storage/am/btree/FieldPrefixNSMTest.java: Line 144: BTreeFieldPrefixNSMLeafFrame frame = new BTreeFieldPrefixNSMLeafFrame(tupleWriter line break -- To view, visit https://asterix-gerrit.ics.uci.edu/840 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0a3cb855768dfd0cd1da4a5fc9f62aedebcbc5f Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
