abdullah alamoudi has posted comments on this change. Change subject: Add Unit Tests for Feed Runtime Input Handler ......................................................................
Patch Set 3: (70 comments) https://asterix-gerrit.ics.uci.edu/#/c/866/3/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java: Line 113: System.err.println("Producer is waking up consumer"); > MAJOR SonarQube violation: Done Line 143: System.err.println("nextFrame() called. inputHandler is in mode: " + mode.toString()); > MAJOR SonarQube violation: Done Line 182: System.err.println("starting discard(frame)"); > MAJOR SonarQube violation: Done Line 186: System.err.println("Spilling to disk is enabled. Will try that"); > MAJOR SonarQube violation: Done Line 195: System.err.println("Spilling to disk is disabled. Will try to get a buffer"); > MAJOR SonarQube violation: Done Line 200: System.err.println("Was able to get a buffer"); > MAJOR SonarQube violation: Done Line 211: System.err.println("in discard(frame). Discard allowance has been consumed. --> Stalling"); > MAJOR SonarQube violation: Done Line 216: System.err.println("in discard(frame). So far, I have discarded " + numDiscarded); > MAJOR SonarQube violation: Done Line 229: System.err.println("Spilling is disabled --> discardOrStall(frame)"); > MAJOR SonarQube violation: Done Line 241: System.err.println("Discard is disabled --> stall(frame)"); > MAJOR SonarQube violation: Done Line 250: System.err.println("in stall(frame). So far, I have stalled " + numStalled); > MAJOR SonarQube violation: Done Line 256: System.err.println("in stall(frame). Spilling is enabled so we will attempt to spill"); > MAJOR SonarQube violation: Done Line 260: if (DEBUG) { > MAJOR SonarQube violation: Done Line 261: System.err.println( > MAJOR SonarQube violation: Done Line 273: System.err.println("Producer is waking up consumer"); > MAJOR SonarQube violation: Done Line 280: System.err.println("in stall(frame). Spilling is disabled. We will subscribe to frame pool"); > MAJOR SonarQube violation: Done Line 289: System.err.println("stall(frame) has been completed. Notifying the consumer that a frame is ready"); > MAJOR SonarQube violation: Done Line 293: System.err.println("Producer is waking up consumer"); > MAJOR SonarQube violation: Done Line 315: if (DEBUG) { > MAJOR SonarQube violation: Done Line 316: System.err.println("Producer is waking up consumer"); > MAJOR SonarQube violation: Done Line 321: } catch (InterruptedException e) { > CRITICAL SonarQube violation: Waiting till the interface fix is in Line 326: System.err.println("Couldn't allocate memory --> exitProcessState(frame)"); > MAJOR SonarQube violation: Done Line 347: if (DEBUG) { > MAJOR SonarQube violation: Done Line 348: System.err.println("Producer is waking up consumer (size of inbox = 1)"); > MAJOR SonarQube violation: Done Line 358: System.err.println("Producer is waking up consumer"); > MAJOR SonarQube violation: Done Line 368: if (DEBUG) { > MAJOR SonarQube violation: Done Line 369: System.err.println("Producer is waking up consumer"); > MAJOR SonarQube violation: Done Line 490: System.err.println("Consumer is going to sleep"); > MAJOR SonarQube violation: Done Line 495: System.err.println("Consumer is waking up"); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/866/3/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameAction.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameAction.java: Line 28: public FrameAction() { > MAJOR SonarQube violation: Done Line 33: System.err.println("FrameAction: My subscription is being answered"); > MAJOR SonarQube violation: Done Line 40: System.err.println("FrameAction: Waking up waiting threads"); > MAJOR SonarQube violation: Done Line 48: System.err.println("FrameAction: Attempting to get allocated buffer"); > MAJOR SonarQube violation: Done Line 52: System.err.println("FrameAction: Allocated buffer is not ready yet. I will wait for it"); > MAJOR SonarQube violation: Done Line 56: System.err.println("FrameAction: Awoken Up"); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/866/3/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameSpiller.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameSpiller.java: Line 92: try { > MAJOR SonarQube violation: Not applicable here since we will keep the resource and will remove it in a different call. https://asterix-gerrit.ics.uci.edu/#/c/866/3/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/ConcurrentFramePool.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/ConcurrentFramePool.java: Line 67: System.err.println("Unable to allocate buffer since subscribers are in-line. Number of subscribers = " > MAJOR SonarQube violation: Done Line 79: System.err.println("Unable to allocate buffer without exceeding budget. Remaining = " + remaining() > MAJOR SonarQube violation: Done Line 112: System.err.println("Unable to allocate buffer without exceeding budget. Remaining = " + remaining() > MAJOR SonarQube violation: Done Line 123: System.err.println("Unable to allocate buffer since subscribers are in-line. Number of subscribers = " > MAJOR SonarQube violation: Done Line 198: System.err.println("Releasing " + multiples + " frames. Remaining frames = " + remaining()); > MAJOR SonarQube violation: Done Line 216: System.err.println("Attempting to callback a subscriber that requested 1 frame"); > MAJOR SonarQube violation: Done Line 221: System.err.println("Attempting to callback a subscriber that requested " > MAJOR SonarQube violation: Done Line 224: buffer = getIgnoreSubscribers(frameAction.getSize()); > MAJOR SonarQube violation: Done Line 236: System.err.println( > MAJOR SonarQube violation: Done Line 242: System.err.println("Failed to allocate requested frames"); > MAJOR SonarQube violation: Done Line 248: System.err.println(subscribers.size() + " remaining subscribers"); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/866/3/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/ConcurrentFramePoolUnitTest.java File asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/ConcurrentFramePoolUnitTest.java: Line 478: Assert.fail(); > CRITICAL SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/866/3/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/InputHandlerTest.java File asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/InputHandlerTest.java: Line 293: Thread.sleep(WAIT_DURATION); > MAJOR SonarQube violation: Done Line 369: Thread.sleep(WAIT_DURATION); > MAJOR SonarQube violation: Done Line 381: Thread.sleep(WAIT_DURATION); > MAJOR SonarQube violation: Done Line 386: Thread.sleep(WAIT_DURATION); > MAJOR SonarQube violation: Done Line 442: Thread.sleep(WAIT_DURATION); > MAJOR SonarQube violation: Done Line 504: Thread.sleep(WAIT_DURATION); > MAJOR SonarQube violation: Done Line 519: Thread.sleep(WAIT_DURATION); > MAJOR SonarQube violation: Done Line 558: Thread.sleep(WAIT_DURATION); > MAJOR SonarQube violation: Done Line 575: Thread.sleep(WAIT_DURATION); > MAJOR SonarQube violation: Done Line 656: Thread.sleep(WAIT_DURATION); > MAJOR SonarQube violation: Done Line 701: Thread.sleep(WAIT_DURATION); > MAJOR SonarQube violation: Done Line 717: Thread.sleep(WAIT_DURATION); > MAJOR SonarQube violation: Done Line 731: Thread.sleep(WAIT_DURATION); > MAJOR SonarQube violation: Done Line 775: Thread.sleep(WAIT_DURATION); > MAJOR SonarQube violation: Done Line 834: Thread.sleep(WAIT_DURATION); > MAJOR SonarQube violation: Done Line 850: Thread.sleep(WAIT_DURATION); > MAJOR SonarQube violation: Done Line 880: Assert.fail(); > CRITICAL SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/866/3/hyracks-fullstack/hyracks/hyracks-api/src/test/java/org/apache/hyracks/api/test/TestFrameWriter.java File hyracks-fullstack/hyracks/hyracks-api/src/test/java/org/apache/hyracks/api/test/TestFrameWriter.java: Line 51: Thread.sleep(openDuration); > MAJOR SonarQube violation: Done Line 67: Thread.sleep(nextDuration); > MAJOR SonarQube violation: Done Line 83: Thread.sleep(flushDuration); > MAJOR SonarQube violation: Done Line 99: Thread.sleep(failDuration); > MAJOR SonarQube violation: Done Line 115: Thread.sleep(closeDuration); > MAJOR SonarQube violation: Done -- To view, visit https://asterix-gerrit.ics.uci.edu/866 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7088f489a7d53dee8cf6cdbf5baa7cd8d3884f55 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
