Ian Maxon has posted comments on this change. Change subject: ASTERIXDB-1425 & ASTERIXDB-1450: Fix LogReader random reads ......................................................................
Patch Set 5: Code-Review+1 (3 comments) Overall seems fine, I just have a couple questions. It's great to have the TxnLogFile abstraction though, dealing with the file channel there always felt odd to me. https://asterix-gerrit.ics.uci.edu/#/c/867/5/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java: Line 563: untouchLogFile(logFileRef.getLogFileId()); Why the split between close and untouch? Line 583: } Is it the case that if the readercount is 0, we don't close the channel until the file gets rotated out? https://asterix-gerrit.ics.uci.edu/#/c/867/5/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java: Line 271: continue; Didn't it use to be that truncated would do what LARGE_RECORD does now? How do we tell between a really big log record that is too big to fit in the read buffer vs. a truly truncated record? -- To view, visit https://asterix-gerrit.ics.uci.edu/867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c75ca4a7c8fe197451126392389d4baecbd7e45 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-HasComments: Yes
