Murtadha Hubail has posted comments on this change. Change subject: Fix CC Nullpointer when Log Level > FINEST ......................................................................
Patch Set 2: The problem here is that the logger level is not set to the value in the configuration until startApplication() is called. So, during WorkQueue initialization the level is the default level value (INFO) which prevents the AtomicIntegers from being initialized. While fixing this might need discussion, I don't think it is a good idea to base any operation, except logging messages, on the log level. I suggest you replace COUNT_LOGGING_LEVEL by a static boolean DEBUG and all (LOGGER.isLoggable(COUNT_LOGGING_LEVEL) by if(DEBUG). When the global log level issue is resolved, we can simply initialize DEBUG value based on the log level. I will open a JIRA issue to capture the logging level initialization problem. -- To view, visit https://asterix-gerrit.ics.uci.edu/870 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-HasComments: No
