Copilot commented on code in PR #654:
URL: https://github.com/apache/burr/pull/654#discussion_r2785881572


##########
pyproject.toml:
##########
@@ -168,7 +168,7 @@ tracking-server = [
 ]
 
 pydantic = [
-  "pydantic"
+  "pydantic>=2.11"
 ]

Review Comment:
   Requiring `pydantic>=2.11` doesn’t itself “avoid model_fields deprecations”; 
it actually makes it more likely users hit them. The codebase still accesses 
`model_fields` on instances (e.g., `burr/integrations/pydantic.py` uses 
`model.model_fields`), which is deprecated in Pydantic 2.11+. Consider updating 
that usage to `type(model).model_fields` / class-level access (or otherwise 
removing instance access). If no 2.11-specific features are required, consider 
relaxing the minimum to the true required major/minor (e.g., `>=2.0`) once the 
deprecation fix is in place.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to