[ 
https://issues.apache.org/jira/browse/COUCHDB-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14559078#comment-14559078
 ] 

ASF GitHub Bot commented on COUCHDB-2701:
-----------------------------------------

GitHub user eiri opened a pull request:

    https://github.com/apache/couchdb-couch/pull/54

    Fix `active_size` format conversion in `get_db_info` function

    In `active_size` conversion in `couch_db:get_db_info/1` old db reduction's 
size format assumed to be an integer representing active state, when it also 
could be a tuple of active and external sizes.
    
    This handeled correctly, for example, in 
[couch_db_updater.erl](https://github.com/apache/couchdb-couch/blob/master/src/couch_db_updater.erl#L426).
    
    This patch addresses conversion of both possible formats to CouchDB 
`size_info` record.
    
    This closes issue COUCHDB-2701

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eiri/couchdb-couch fix-get-db-info

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #54
    
----
commit e2349f39c23a22c1ed054224f1a8ace68a4366e1
Author: Eric Avdey <e...@eiri.ca>
Date:   2015-05-26T12:59:24Z

    Fix `active_size` format conversion in `get_db_info` function
    
    In `active_size` conversion in `couch_db:get_db_info/1` old db reduction's 
size format assumed to be an integer representing active state, when it also 
could be a tuple of active and external sizes.
    
    This handeled correctly, for example, in 
[couch_db_updater.erl](https://github.com/apache/couchdb-couch/blob/master/src/couch_db_updater.erl#L426).
    
    This patch addresses conversion of both possible formats to CouchDB 
`size_info` record.
    
    This closes issue COUCHDB-2701

----


> Fix active_size format conversion in get_db_info function 
> ----------------------------------------------------------
>
>                 Key: COUCHDB-2701
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2701
>             Project: CouchDB
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: BigCouch
>            Reporter: Eric Avdey
>            Priority: Trivial
>
> There've been made an error in {{active_size}} conversion during the windsor 
> merge.
> In {{couch_db:get_db_info/1}} db reduction's size format assumed to be an 
> integer representing active state, when it also could be a tuple of active 
> and external sizes (reference commit 
> [2b99ce8e|https://github.com/apache/couchdb-couch/commit/2b99ce8e7c2a50fa02b57f888c5cf890ef8706ed]).
> This handeled correctly, for example, in 
> [couch_db_updater.erl|https://github.com/apache/couchdb-couch/blob/master/src/couch_db_updater.erl#L426].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to