Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/651#discussion_r55553488
  
    --- Diff: app/addons/documents/routes-index-editor.js ---
    @@ -28,40 +28,53 @@ define([
       'addons/documents/pagination/pagination.react',
       'addons/documents/header/header.react',
       'addons/documents/header/header.actions',
    +  'addons/documents/sidebar/actions'
     ],
     
     function (app, FauxtonAPI, Helpers, BaseRoute, Documents, 
IndexEditorComponents, ActionsIndexEditor,
               Databases, Components, IndexResultsStores, IndexResultsActions,
    -          IndexResultsComponents, ReactPagination, ReactHeader, 
ReactHeaderActions) {
    +          IndexResultsComponents, ReactPagination, ReactHeader, 
ReactHeaderActions, SidebarActions) {
     
     
       var IndexEditorAndResults = BaseRoute.extend({
    -    layout: 'two_pane',
    +    layout: 'with_tabs_sidebar',
         routes: {
    -      'database/:database/new_view': 'newViewEditor',
    -      'database/:database/new_view/:designDoc': 'newViewEditor',
    +      'database/:database/new_view': {
    +        route: 'createView',
    +        roles: ['fx_loggedIn']
    +      },
    +      'database/:database/new_view/:designDoc': {
    +        route: 'createView',
    +        roles: ['fx_loggedIn']
    +      },
           'database/:database/_design/:ddoc/_view/:view': {
    -        route: 'viewFn',
    +        route: 'showView',
    +        roles: ['fx_loggedIn']
    +      },
    +      'database/:database/_design/:ddoc/_view/:view/edit': {
    --- End diff --
    
    hmm.. changing the route diverges us more from the couchdb routing:
    
    right now
    
    ```
    http://localhost:8000/#/database/blerg/_design/yxc/_view/new-view
    
    
               http://localhost:5984/blerg/_design/yxc/_view/new-view
    ```
    
    that makes it easy to copy / paste stuff around for debugging / development 
of applications that use couchdb views, i can click to the view in the fauxton 
ui and then copy the second part of the url 1:1 into my application code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to