Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/106#discussion_r56053708
--- Diff: src/chttpd.erl ---
@@ -1068,3 +1057,18 @@ stack_hash(Stack) ->
%% dedicated chunk.
chunked_response_buffer_size() ->
config:get_integer("httpd", "chunked_response_buffer", 1490).
+
+basic_headers(Req, Headers0) ->
+ Headers = Headers0
+ ++ server_header()
+ ++ couch_httpd_auth:cookie_auth_header(Req, Headers0),
+ chttpd_cors:headers(Req, Headers).
+
+handle_response(Req, Code, Headers, Args, Type) ->
+ couch_stats:increment_counter([couchdb, httpd_status_codes, Code]),
+ respond_(Req, Code, Headers, Args, Type).
+
+respond_(#httpd{mochi_req = MochiReq}, Code, Headers, _Args,
start_response) ->
--- End diff --
Out of sheer curiosity, where such peculiar naming came from? Is there some
erlang convention I'm not aware of? Don't get me wrong, I'm indifferent on the
matter, it just looks a bit pythonesque.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
