Github user iilyak commented on the pull request:
https://github.com/apache/couchdb-couch/pull/141#issuecomment-200047680
> @eiri
https://github.com/cloudant/couchdb-couch/pull/11#issuecomment-199885171
To be honest I don't find your version much clearer on what it is doing or
more idiomatic than mine foldl. It might be jiffy faster, but we are talking
about traversing 5-6 elements list...
The point was not about performance but to improve readability by
eliminating magic numbers.
> I guess we can refactor that tokenizer into its own function, though it's
not like it's going to be used outside of deleted_filename. So what exactly is
the gain of a hair splitting here?
Extracting black magic into a function so it is easier to find and fix
later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
