Github user eiri commented on the pull request:
https://github.com/apache/couchdb-couch/pull/161#issuecomment-207611080
@rnewson @iilyak - the comments addressed.
Regarding rename-then-delete approach, just to move the comment here out of
the outdated diff:
As described here https://issues.apache.org/jira/browse/COUCHDB-1003 , this
is done because deletion of large files on block-oriented filesystems can take
time, so the file first moved into `.deleted` directory that got cleaned up on
couch start.
@rnewson if you think this is not applicable here, I'll remove the rename
part, I was just reproducing behaviour of `nuke_dir/2` as it was before this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
