Github user kxepal commented on a diff in the pull request:

    https://github.com/apache/couchdb-chttpd/pull/118#discussion_r62553105
  
    --- Diff: src/chttpd_db.erl ---
    @@ -448,6 +448,7 @@ db_req(#httpd{method='POST', path_parts=[_, 
<<"_bulk_get">>]}=Req, Db) ->
             undefined ->
                 throw({bad_request, <<"Missing JSON list of 'docs'.">>});
             Docs ->
    +            couch_stats:update_histogram([couchdb, httpd, bulk_reads], 
length(Docs)),
    --- End diff --
    
    I think the name is confusing. If we want to count only "/_bulk_get" 
requests here, better give such name to the metric instead of generic 
bulk_reads. Otherwise, if you want to use "bulk_reads", should we count 
requests with include_docs=true to views and all_docs as bulk reads?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to