Github user nickva commented on the issue:

    https://github.com/apache/couchdb/pull/425
  
    @kxepal  It would be useful to have a logging / warning only value for this 
setting. Is it better to call the value "warning?" or have a new additional one 
"if enabled don't actually enable, but just log" setting. That might be more 
confusing... What did you have in mind, what's a better setting?
    
    Sorry, didn't follow this part:
    
    > "But here you also add input_line as is which is much longer than 
reduce_line
    
    What do you mean by adding the input line? The code does the opposite, it 
subtracts the code size from the line length so it considers data only. Before 
it was broken the way it worked. So someone could have created a 2MB  function 
body and then they could create reduce values as big as 1MB.
    
    In general this is a fix to get this code to be useful. Currently because 
of how restricted the size is, it is actually disabled in production. 
Periodically customers without realizing create large reduce values, for 
example by doing `return values`, so trying to fix it.
    
    > With reduce_limit = "log" you can also eventually cause high IO activity 
since all these data will get dumped on log 
    
    Log is supposed to be enabled for a while as a diagnostic setting. After a 
while it would be obvious if it works or not. Notice, the log output only 
includes the line lengths, specifically to not flood it with too much data.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to