GitHub user nickva opened a pull request:
https://github.com/apache/couchdb-couch-replicator/pull/45
Fix replicator manager `stop` change feed callback
```
changes_reader_cb({stop, EndSeq, _Pending}, ...) ->
...
```
at one point used to handle changes from `fabric:changes`. It was later
optimized to use shard change feeds, but shard change feed callbacks don't
get
pending info with the `stop` message.
As a result replicator manager would always rescan all the changes in a
shard
on any new change.
For reference, where `couch_changes.erl` calls the callback:
https://github.com/apache/couchdb-couch/blob/master/src/couch_changes.erl#L654
Jira: COUCHDB-3104
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/couchdb-couch-replicator
3104-fix-replicator-manager-changes-feed-checkpoint
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch-replicator/pull/45.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #45
----
commit 40a087630b9b6688fe2db87f1e8adc7972c4a0c9
Author: Nick Vatamaniuc <vatam...@gmail.com>
Date: 2016-08-15T06:50:56Z
Fix replicator manager `stop` change feed callback
```
changes_reader_cb({stop, EndSeq, _Pending}, ...) ->
...
```
at one point used to handle changes from `fabric:changes`. It was later
optimized to use shard change feeds, but shard change feed callbacks don't
get
pending info with the `stop` message.
As a result replicator manager would always rescan all the changes in a
shard
on any new change.
For reference, where `couch_changes.erl` calls the callback:
https://github.com/apache/couchdb-couch/blob/master/src/couch_changes.erl#L654
Jira: COUCHDB-3104
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
