Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/56#discussion_r77600024
--- Diff: src/couch_mrview_http.erl ---
@@ -469,10 +469,16 @@ parse_params(Props, Keys, #mrargs{}=Args0, Options) ->
IsDecoded = lists:member(decoded, Options),
% group_level set to undefined to detect if explicitly set by user
Args1 = Args0#mrargs{keys=Keys, group=undefined,
group_level=undefined},
- lists:foldl(fun({K, V}, Acc) ->
+ Args2 = lists:foldl(fun({K, V}, Acc) ->
parse_param(K, V, Acc, IsDecoded)
- end, Args1, Props).
-
+ end, Args1, Props),
+ Limit = Args2#mrargs.limit,
+ case config:get_integer("couch_db", " default_query_limit", -1) of
--- End diff --
I see. My point was about thin difference between `default_query_limit` and
`max_query_limit`. First one assumes that you can specify any value instead to
override the default, even greater than. The second implies (at least for me)
that I cannot beat that value in config file, so `?limit=100` with
`max_query_limit=10` will still return 10 records back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
