Github user jaydoane commented on the issue:

    https://github.com/apache/couchdb-couch-mrview/pull/58
  
    @davisp, thanks for the diff. I updated the PR, added `Pid` and `Ref` 
params to `recompact_loop` function, and fixed the `State` name issue for 
`'$gen_cast'` case.
    
    One concern is that while we have a test for `couch_mrview:compact/3`, we 
don't actually test `recompact` in it. Do you think it's sufficient to just 
unit test `recompact` and `recompact_loop`, or do you think it warrants a full 
on integration style test such as in `couch_mrview_compact_tests`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to