Github user iilyak commented on the issue:

    https://github.com/apache/couchdb-fabric/pull/86
  
    I agree with @nickva. Let's leave replicator problem for the latter. +1 
from me. The test doesn't test the changed line but it is useful anyway. Tests 
pass locally.
    ```
        Running test function(s):
          fabric_doc_open_revs:open_doc_revs_test_/0
    ======================== EUnit ========================
    fabric_doc_open_revs:333: check_empty_response_not_quorum...[0.008 s] ok
    fabric_doc_open_revs:341: check_basic_response...[0.009 s] ok
    fabric_doc_open_revs:349: check_finish_quorum...[0.002 s] ok
    fabric_doc_open_revs:361: check_finish_quorum_newer...[0.002 s] ok
    fabric_doc_open_revs:378: check_no_quorum_on_second...ok
    fabric_doc_open_revs:392: check_done_on_third...ok
    fabric_doc_open_revs:405: check_specific_revs_first_msg...ok
    fabric_doc_open_revs:415: check_revs_done_on_agreement...ok
    fabric_doc_open_revs:425: check_latest_true...ok
    fabric_doc_open_revs:436: check_ancestor_counted_in_quorum...ok
    fabric_doc_open_revs:453: check_not_found_counts_for_descendant...ok
    fabric_doc_open_revs:470: check_worker_error_skipped...ok
    fabric_doc_open_revs:484: check_quorum_only_counts_valid_responses...ok
    fabric_doc_open_revs:498: check_empty_list_when_no_workers_reply...ok 
<---------
    fabric_doc_open_revs:512: 
check_not_found_replies_are_removed_when_doc_found...ok
    fabric_doc_open_revs:519: 
check_not_found_returned_when_one_of_docs_not_found...ok
    fabric_doc_open_revs:526: check_not_found_returned_when_doc_not_found...ok
    =======================================================
      All 17 tests passed.
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to