Github user iilyak commented on the issue:

    https://github.com/apache/couchdb-couch/pull/226
  
    +1. tests pass locally
    ```
        Running test function(s):
          couch_doc_json_tests:json_doc_test_/0
          couch_doc_tests:validate_docid_test_/0
    ======================== EUnit ========================
    couch_doc_tests:89: validate_docid_test_...[0.003 s] ok
    couch_doc_tests:90: validate_docid_test_...ok
    couch_doc_tests:91: validate_docid_test_...ok
    couch_doc_tests:92: validate_docid_test_...[0.001 s] ok
    couch_doc_tests:93: validate_docid_test_...ok
    couch_doc_tests:95: validate_docid_test_...ok
    couch_doc_tests:97: validate_docid_test_...ok
    couch_doc_tests:99: validate_docid_test_...ok
    couch_doc_tests:101: validate_docid_test_...ok
    couch_doc_tests:103: validate_docid_test_...ok
    couch_doc_tests:105: validate_docid_test_...ok
    Document from JSON
      couch_doc_json_tests:168: from_json_success_cases (Return an empty 
document for an empty JSON object.)...ok
      couch_doc_json_tests:168: from_json_success_cases (Parses document 
ids.)...ok
      couch_doc_json_tests:168: from_json_success_cases (_design/document 
ids.)...ok
      couch_doc_json_tests:168: from_json_success_cases (_local/document 
ids.)...ok
      couch_doc_json_tests:168: from_json_success_cases (_rev stored in 
revs.)...ok
      couch_doc_json_tests:168: from_json_success_cases (Non underscore 
prefixed fields stored in body.)...ok
      couch_doc_json_tests:168: from_json_success_cases (Attachments are parsed 
correctly.)...[0.011 s] ok
      couch_doc_json_tests:168: from_json_success_cases (_deleted controls the 
deleted field.)...ok
      couch_doc_json_tests:168: from_json_success_cases ({"_deleted": false} is 
ok.)...ok
      couch_doc_json_tests:168: from_json_success_cases (_revisions attribute 
are preferred to _rev.)...ok
      couch_doc_json_tests:168: from_json_success_cases (Drops _revs_info.)...ok
      couch_doc_json_tests:168: from_json_success_cases (Drops _local_seq.)...ok
      couch_doc_json_tests:168: from_json_success_cases (Drops _conflicts.)...ok
      couch_doc_json_tests:168: from_json_success_cases (Drops 
_deleted_conflicts.)...ok
      couch_doc_json_tests:239: from_json_error_cases (arrays are invalid)...ok
      couch_doc_json_tests:239: from_json_error_cases (integers are 
invalid)...ok
      couch_doc_json_tests:239: from_json_error_cases (literals are 
invalid)...ok
      couch_doc_json_tests:239: from_json_error_cases (Document id must be a 
string.)...ok
      couch_doc_json_tests:239: from_json_error_cases (Disallow arbitrary 
underscore prefixed docids.)...ok
      couch_doc_json_tests:239: from_json_error_cases (_rev must be a 
string)...ok
      couch_doc_json_tests:239: from_json_error_cases (_rev must be %d-%s)...ok
      couch_doc_json_tests:245: from_json_error_cases (Error if _rev's integer 
expection is broken.)...ok
      couch_doc_json_tests:239: from_json_error_cases (_revisions.start must be 
an integer.)...ok
      couch_doc_json_tests:239: from_json_error_cases (_revions.ids must be a 
list.)...ok
      couch_doc_json_tests:239: from_json_error_cases (Revision ids must be 
strings.)...ok
      couch_doc_json_tests:239: from_json_error_cases (Underscore prefix fields 
are reserved.)...ok
      [done in 0.088 s]
    Document to JSON
      couch_doc_json_tests:400: to_json_success_cases (Empty docs are {"_id": 
""})...ok
      couch_doc_json_tests:400: to_json_success_cases (_id is added.)...ok
      couch_doc_json_tests:400: to_json_success_cases (_rev is added.)...ok
      couch_doc_json_tests:402: to_json_success_cases (_revisions include with 
revs option)...ok
      couch_doc_json_tests:400: to_json_success_cases (Arbitrary fields are 
added.)...ok
      couch_doc_json_tests:400: to_json_success_cases (Deleted docs no longer 
drop body members.)...ok
      couch_doc_json_tests:400: to_json_success_cases (_revs_info field is 
added correctly.)...ok
      couch_doc_json_tests:400: to_json_success_cases (_local_seq is added as 
an integer.)...ok
      couch_doc_json_tests:400: to_json_success_cases (_conflicts is added as 
an array of strings.)...ok
      couch_doc_json_tests:400: to_json_success_cases (_deleted_conflicsts is 
added as an array of strings.)...ok
      couch_doc_json_tests:400: to_json_success_cases (Attachments attached as 
stubs only include a length.)...ok
      couch_doc_json_tests:402: to_json_success_cases (Attachments included 
inline with attachments option.)...ok
      [done in 0.036 s]
    =======================================================
      All 49 tests passed.
    ``` 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to