[ 
https://issues.apache.org/jira/browse/COUCHDB-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901925#comment-15901925
 ] 

ASF GitHub Bot commented on COUCHDB-3305:
-----------------------------------------

GitHub user iilyak opened a pull request:

    https://github.com/apache/couchdb-couch/pull/234

    Fix initial accumulator value for builtin_sum_rows

    This a fixup for https://github.com/apache/couchdb-couch/pull/229.
    The initial value for accumulator suppose to be 0. Since the result of
    sum and count is integer. The problem was discovered by dialyzer.
    
    COUCHDB-3305

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-couch 
70794-fix-initial-acc-for-builtin_sum_rows

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch/pull/234.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #234
    
----
commit 1f152daaac23dc96132139fb532786f77becdd64
Author: ILYA Khlopotov <[email protected]>
Date:   2017-03-08T20:24:46Z

    Fix initial accumulator value for builtin_sum_rows
    
    This a fixup for https://github.com/apache/couchdb-couch/pull/229.
    The initial value for accumulator suppose to be 0. Since the result of
    sum and count is integer. The problem was discovered by dialyzer.
    
    COUCHDB-3305

----


> don't crash with invalid input to built in reducer function
> -----------------------------------------------------------
>
>                 Key: COUCHDB-3305
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-3305
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>            Reporter: Tony Sun
>            Assignee: Tony Sun
>
> When users use a built in reduce function such as _sum, and documents have 
> invalid input, we currently crash and return a 500 with error message. This 
> improvement will return an error row without crashing for better debugging.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to