eiri commented on a change in pull request #560: Fix broken eunit test in
changes_since_test_ test suite
URL: https://github.com/apache/couchdb/pull/560#discussion_r119608076
##########
File path: src/couch_mrview/src/couch_mrview_test_util.erl
##########
@@ -53,7 +53,8 @@ ddoc(changes) ->
couch_doc:from_json_obj({[
{<<"_id">>, <<"_design/bar">>},
{<<"options">>, {[
- {<<"seq_indexed">>, true}
+ {<<"seq_indexed">>, true},
+ {<<"keyseq_indexed">>, true}
Review comment:
It is valid to have only seq btree enabled on a view, i.e. all tests should
pass even with key-seq btree not built. If anything we should expand the tests
to assert both variants.
Can you explain, please, why do you think changing a scope of
`couch_mrview_changes_since_tests.erl` to test `key-seq` instead of `seq` is
the right fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
