iilyak commented on a change in pull request #539: Close idle dbs
URL: https://github.com/apache/couchdb/pull/539#discussion_r119703241
##########
File path: src/couch/src/couch_file.erl
##########
@@ -338,12 +339,33 @@ init_status_error(ReturnPid, Ref, Error) ->
ReturnPid ! {Ref, self(), Error},
ignore.
+last_read(Fd) when is_pid(Fd) ->
Review comment:
The name of the function is a bit confusing. When I read it first time I
thought it would return a timestamp but it returns relative time since last
read. Naming is hard. Few options:
- last_read - i.e. keep it as is
- seconds_since_read
- seconds_since_access - if we want to account for both writes and reads
- seconds_after_read
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
