SinanGabel commented on issue #53: bring follow library under Nano's wing URL: https://github.com/apache/couchdb-nano/pull/53#issuecomment-316040321 Really good plan! On 18 July 2017 at 13:41, Glynn Bird <notificati...@github.com> wrote: > Overview > > Currently Nano uses a the follow <https://www.npmjs.com/package/follow> > library as a dependency to handle changes feed subscription. Unfortunately, > follow is not maintained. The nice people at Cloudant have taken the code > and fixed it up and published it here > <https://github.com/cloudant-labs/cloudant-follow>. This PR > <https://github.com/apache/couchdb-nano/pull/51> proposes to depend on > the cloudant-follow fork, but I am proposing something different: > > 1. Bring the follow codebase into the Nano project (it is published > under an Apache-2.0 license) > 2. Remove follow as a dependency > 3. In the future refactor the follow code to be more in keeping with > the > > Testing recommendations > > This should be a drop-in replacement of the previous version. The only > difference is that the follow code lives in this repo and not as a > dependency. > > I've brought in the follow tests too. Unfortunately they rely on > CouchDB1.6 so I've altered the testing sequence to run our core tests with > CouchDB2 then switch over to CouchDB1.6 for the follow tests. > > See npm run coretests & npm run followtests in package.json. > GitHub issue number Related Pull Requests > > See issue #28 <https://github.com/apache/couchdb-nano/issues/28> & pull > #51 <https://github.com/apache/couchdb-nano/pull/51> > Checklist > > - [x ] Code is written and works correctly; > - Changes are covered by tests; > - [x ] Documentation reflects the changes; > > ------------------------------ > You can view, comment on, or merge this pull request online at: > > https://github.com/apache/couchdb-nano/pull/53 > Commit Summary > > - bring follow library under Nano's wing > > File Changes > > - *M* README.md > <https://github.com/apache/couchdb-nano/pull/53/files#diff-0> (7) > - *A* follow.md > <https://github.com/apache/couchdb-nano/pull/53/files#diff-1> (210) > - *A* follow_tests/couch.js > <https://github.com/apache/couchdb-nano/pull/53/files#diff-2> (176) > - *A* follow_tests/follow.js > <https://github.com/apache/couchdb-nano/pull/53/files#diff-3> (258) > - *A* follow_tests/issues.js > <https://github.com/apache/couchdb-nano/pull/53/files#diff-4> (92) > - *A* follow_tests/stream.js > <https://github.com/apache/couchdb-nano/pull/53/files#diff-5> (574) > - *A* lib/follow/api.js > <https://github.com/apache/couchdb-nano/pull/53/files#diff-6> (35) > - *A* lib/follow/lib/feed.js > <https://github.com/apache/couchdb-nano/pull/53/files#diff-7> (694) > - *A* lib/follow/lib/index.js > <https://github.com/apache/couchdb-nano/pull/53/files#diff-8> (51) > - *A* lib/follow/lib/stream.js > <https://github.com/apache/couchdb-nano/pull/53/files#diff-9> (312) > - *M* lib/nano.js > <https://github.com/apache/couchdb-nano/pull/53/files#diff-10> (2) > - *M* package.json > <https://github.com/apache/couchdb-nano/pull/53/files#diff-11> (12) > - *A* scripts/run_couchdb16_on_travis.sh > <https://github.com/apache/couchdb-nano/pull/53/files#diff-12> (13) > - *A* scripts/stop_couchdb16_on_travis.sh > <https://github.com/apache/couchdb-nano/pull/53/files#diff-13> (7) > > Patch Links: > > - https://github.com/apache/couchdb-nano/pull/53.patch > - https://github.com/apache/couchdb-nano/pull/53.diff > > ? > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/couchdb-nano/pull/53>, or mute the thread > <https://github.com/notifications/unsubscribe-auth/AFU80jKor-M6mguFsMl-WbBn8T_ZEyszks5sPJnmgaJpZM4ObOSt> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
