garrensmith commented on a change in pull request #933: Update for changes to
_cluster_setup endpoint
URL: https://github.com/apache/couchdb-fauxton/pull/933#discussion_r128966227
##########
File path: app/addons/setup/setup.js
##########
@@ -66,6 +99,32 @@ var SetupCurrentAdminPassword = React.createClass({
});
+var SetupNodeCountSetting = React.createClass({
+ getInitialState: function () {
+ return {
+ nodeCountValue: this.props.nodeCountValue
Review comment:
I'm not sure this is correct, you are getting the node count value from the
props but then changing it via state. Props should never be changed. It might
be better to set a default value in the initial state and not use props at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
