davisp commented on a change in pull request #1370: [5/5] Clustered Purge
Implementation
URL: https://github.com/apache/couchdb/pull/1370#discussion_r197337603
##########
File path: src/mem3/src/mem3_rep.erl
##########
@@ -118,6 +121,34 @@ make_local_id(SourceThing, TargetThing, Filter) ->
<<"_local/shard-sync-", S/binary, "-", T/binary, F/binary>>.
+make_purge_id(SourceUUID, TargetUUID) ->
+ <<"_local/purge-mem3-", SourceUUID/binary, "-", TargetUUID/binary>>.
Review comment:
That versioning thing was something that was planned for a rollback but
after more development it became clear that we can't really do a parity
rollback so there's no reason to try and code it. Due to how we want to
transform the current purge data structure into a tree there's no obvious way
to undo a tree into the existing structure without a whole bunch of code that
would be exceedingly rarely executed. Given that complexity tradeoff it seems a
lot more useful to just test the upgrade thoroughly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
