davisp commented on a change in pull request #1602: Remove runtime
configurability of core system components
URL: https://github.com/apache/couchdb/pull/1602#discussion_r218835624
##########
File path: src/couch/src/couch_secondary_sup.erl
##########
@@ -26,6 +26,16 @@ init([]) ->
worker,
dynamic}
],
+ Daemons = [
+ {"index_server", "{couch_index_server, start_link, []}"},
Review comment:
It seems a bit silly to keep these as strings just to convert all of the
terms in the following list comprehension. I'd at least like to remove that bit
of silly for this supervisor. I'd also suggest that we just write out the child
specs directly in the SecondarySupervisors list above given that's the more
traditional way of doing things (or at least using a helper that gets mapped
over the name/mfa pairs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
