davisp commented on a change in pull request #1662: Do not crash couch_log
application when gen_* servers send extra args
URL: https://github.com/apache/couchdb/pull/1662#discussion_r226087196
##########
File path: src/couch_log/src/couch_log_formatter.erl
##########
@@ -58,18 +58,18 @@ format(Level, Pid, Msg) ->
format({error, _GL, {Pid, "** Generic server " ++ _, Args}}) ->
Review comment:
I also think it'd be a good idea to have this function be do_format, and
then we can wrap it in something ilke:
```erlang
format(Arg) ->
try
do_format(Arg)
catch T:R ->
log_that_it_bew_up(T, R)
end.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
