garrensmith commented on a change in pull request #1656: Partition review fixes
URL: https://github.com/apache/couchdb/pull/1656#discussion_r226233423
##########
File path: src/chttpd/src/chttpd_view.erl
##########
@@ -151,8 +151,8 @@ check_partition_restrictions(#mrargs{} = Args) ->
{<<"stable">>, Args#mrargs.stable, true},
{<<"conflicts">>, Args#mrargs.conflicts, true}
],
- lists:foreach(fun ({Param, Field, Value}) ->
- case Field =:= Value of
+ lists:foreach(fun ({Param, ArgValue, RestrictedValue}) ->
+ case ArgValue =:= RestrictedValue of
true ->
Msg = [<<"`">>, Param, <<"=true` is not supported in this
view.">>],
Review comment:
Correct. All the restriction values above are true. I can simplify the
function to just check for true if you want?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
