iilyak commented on a change in pull request #1708: #1705 Add UUID attribute to
welcome message
URL: https://github.com/apache/couchdb/pull/1708#discussion_r230334471
##########
File path: src/chttpd/src/chttpd_misc.erl
##########
@@ -50,6 +50,7 @@ handle_welcome_req(#httpd{method='GET'}=Req, WelcomeMessage)
->
{couchdb, WelcomeMessage},
{version, list_to_binary(couch_server:get_version())},
{git_sha, list_to_binary(couch_server:get_git_sha())},
+ {uuid, list_to_binary(couch_server:get_uuid())},
Review comment:
`couch_server:get_uuid/0` returns binary
(https://github.com/apache/couchdb/blob/master/src/couch/src/couch_server.erl#L68
`?l2b` macro stands for `list to binary`). Attempt to call `list_to_binary` on
a binary argument causing `badarg` exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
