garrensmith commented on a change in pull request #1789: New Feature: Database
Partitions
URL: https://github.com/apache/couchdb/pull/1789#discussion_r238649278
##########
File path: src/couch_mrview/src/couch_mrview_index.erl
##########
@@ -264,6 +267,29 @@ get_ddoc(DbName, DesignDocs, DDocId) ->
end).
+set_partitioned(Db, State) ->
+ #mrst{
+ design_opts = DesignOpts
+ } = State,
+ DbPartitioned = couch_db:is_partitioned(Db),
+ ViewPartitioned = proplists:get_value(<<"partitioned">>, DesignOpts),
Review comment:
I think we should do `ViewPartitioned =
proplists:get_value(<<"partitioned">>, DesignOpts, DbPartitioned),` here. That
would reduce two of the case statement lines since if there is no option then
the view partition option is the same as the `DbPartitioned` value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
