wohali commented on a change in pull request #40: Detect Arch Support
URL: https://github.com/apache/couchdb-pkg/pull/40#discussion_r240301111
##########
File path: Makefile
##########
@@ -154,10 +154,12 @@ build-rpm:
# ######################################
copy-pkgs:
- -chmod a+rwx ../rpmbuild/RPMS/x86_64/couchdb-* ../couchdb/couchdb_*
2>/dev/null
- -mkdir -p pkgs/couch/$(DIST) && chmod 777 pkgs/couch/$(DIST)
- -cp ../rpmbuild/RPMS/x86_64/couchdb-* pkgs/couch/$(DIST) 2>/dev/null
- -cp ../couchdb/couchdb_* pkgs/couch/$(DIST) 2>/dev/null
+ if [ "$(shell arch)" = "x84_64" ]; then
\
Review comment:
Can't you make this more generic rather than putting the entire 4 lines into
an if statement? Perhaps something like:
```
copy-pkgs: ARCH=$(shell arch)
copy-pkgs:
chmod a+rwx ../rpmbuild/RPMS/$(ARCH)/couchdb-* ../couchdb/couchdb_@
2>/dev/null
# etc etc etc
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
