davisp commented on a change in pull request #1804: Make view query limits
configurable
URL: https://github.com/apache/couchdb/pull/1804#discussion_r249871518
##########
File path: test/elixir/test/partition_all_docs_test.exs
##########
@@ -116,6 +116,43 @@ defmodule PartitionAllDocsTest do
assert ids == ["foo:22"]
end
+ test "partition all docs can set query limits", context do
+ resp = Couch.get("/_membership")
+ %{:body => body} = resp
+
+ Enum.each(body["all_nodes"], fn node ->
+ resp =
Couch.put("/_node/#{node}/_config/query_server_config/partition_query_limit",
body: "\"2000\"")
Review comment:
Re-reading again, and just noticed this. You should use set_config which
takes care of removing the config change after the test finishes. There's an
example here:
https://github.com/apache/couchdb/blob/8d2af71f2896d5f75ceb0f780993493fcecdf49d/test/elixir/test/partition_size_limit_test.exs#L15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
